Merge pull request #157 from SylvainCorlay/new_comm

Allow passing a comm_id to new_comm
jupyter · Jun 19, 2015 · 6902409 · 6902409
2 parents 719f9ac + 0e18fd7
commit 6902409
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/notebook/static/services/kernels/comm.js b/notebook/static/services/kernels/comm.js
@@ -31,12 +31,14 @@ define([
         }
     };
 
-    CommManager.prototype.new_comm = function (target_name, data, callbacks, metadata) {
+    CommManager.prototype.new_comm = function (target_name, data, callbacks, metadata, comm_id) {
         /**
          * Create a new Comm, register it, and open its Kernel-side counterpart
-         * Mimics the auto-registration in `Comm.__init__` in the Jupyter Comm
+         * Mimics the auto-registration in `Comm.__init__` in the Jupyter Comm.
+         *
+         * argument comm_id is optional
          */
-        var comm = new Comm(target_name);
+        var comm = new Comm(target_name, comm_id);
         this.register_comm(comm);
         comm.open(data, callbacks, metadata);
         return comm;