Skip to content

Commit

Permalink
Message for callback is converted to update_display_data
Browse files Browse the repository at this point in the history
This was already the case, but it was hidden by the tests using
.msg_type at the top-level of the message, which was not updated.
  • Loading branch information
takluyver committed Nov 6, 2018
1 parent 3ab2d12 commit 826ee65
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions notebook/tests/notebook/display_id.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ casper.notebook_test(function () {
});

this.wait_for_output(1);
this.wait_for_idle()
this.wait_for_idle();

this.then(function () {
var outputs = get_outputs(1);
Expand Down Expand Up @@ -151,7 +151,7 @@ casper.notebook_test(function () {
cell.execute();

Jupyter.notebook.insert_cell_at_index("code", 5);
var cell = Jupyter.notebook.get_cell(5);
cell = Jupyter.notebook.get_cell(5);
cell.set_text([
"display_with_id(10, 'result', update=True)",
"1",
Expand Down Expand Up @@ -179,7 +179,7 @@ casper.notebook_test(function () {
this.test.assertEquals(callback_results[1].output_type, 'update_display_data', 'check output_type 1');
this.test.assertEquals(callback_results[1].transient.display_id, 'here', 'display id 1');
this.test.assertEquals(callback_results[1].data['text/plain'], '6', 'value');
this.test.assertEquals(callback_results[2].output_type, 'display_data', 'check output_type 2');
this.test.assertEquals(callback_results[2].output_type, 'update_display_data', 'check output_type 2');
this.test.assertEquals(callback_results[2].transient.display_id, 'here', 'check display id 2');
this.test.assertEquals(callback_results[2].data['text/plain'], '7', 'value');
this.test.assertEquals(callback_results[3].output_type, 'update_display_data', 'check output_type 3');
Expand Down

0 comments on commit 826ee65

Please sign in to comment.