Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for emoji? #2199

Closed
ConstantinoSchillebeeckx opened this issue Feb 16, 2017 · 6 comments
Closed

support for emoji? #2199

ConstantinoSchillebeeckx opened this issue Feb 16, 2017 · 6 comments

Comments

@ConstantinoSchillebeeckx

Is there any plan for supporting emoji codes in the markdown cells? 😀

@Carreau
Copy link
Member

Carreau commented Feb 17, 2017

Is there any plan for supporting emoji codes in the markdown cells

Not in the document spec:

Not currently, because emojicode is not in the standard markdown spec, and we want to avoid inventing our own. If it get standardized in CommonMark and most of the markdown tooling we use support it why not.

Maybe in the UI ?

I guess, you could write and extension that tab complete to the equivalent unicode character. That will be fine, and that can be done now. There are plenty of other things we could tab-complete to/from

I've already seen a notebook named 📓.🐍 so that should not be a problem.

@Carreau Carreau added this to the Backlog milestone Feb 17, 2017
@rafa2000
Copy link

rafa2000 commented Jul 14, 2017

If it is not in the document spec, someone may be slumbering. I vote this up too. Emoji is a great tool to put markers on your markdown documents, which is the glue text on Jupyter.

The Emoji CheatSheet list the following software supporting emoji in their markdown (most of those are in the form of social software): Campfire, GitHub, Basecamp, Redbooth, Trac, Flowdock, Sprint.ly, Kandan, Textbox.io, Kippt, Redmine, JabbR, Trello, Hall, Qiita, Zendesk, Ruby China, Grove, Idobata, NodeBB Forums, Slack, Streamup, OrganisedMinds, Hackpad, Cryptbin, Kato, Reportedly, Cheerful Ghost, IRCCloud, Dashcube, MyVideoGameList, Subrosa, Sococo, Quip, And Bang, Bonusly, Discourse, Ello, Twemoji Awesome, Got Chosen, Flow, ReadMe.io, esa, DBook, Groups.io, TeamworkChat, Damn Bugs, Let's Chat, Buildkite, ChatGrape, Dokuwiki, Usersnap, Discord, Status Hero, Morfy, Bitbucket, Gitter, Yellow, YouTube, Habitica and Mattermost.

Part of the work may already been done within the emoji python library (https://stackoverflow.com/questions/42279182/importing-emoji-codes-into-jupyter-notebooks). Just: pip install emoji and enjoy! Of course we need it in the markdown too, Oh well.

👍 ✨ 🐫 🎉 🚀 🤘 :octocat:

@Carreau
Copy link
Member

Carreau commented Jul 19, 2017

someone may be slumbering

Are you proposing yourself to make PRs to all the area of the project that handle markdown to include the ability to understand emojicode ? Jupyter is maintained a lot by volunteers and feature get implemented only if people contribute to it.

And again unicode works great already :

screen shot 2017-07-19 at 06 52 34

@BrenBarn
Copy link

@Carreau: What exactly is "the document spec"? The thing is that the Jupyter documentation says it "supports Github flavored markdown". It says this only in the context of allowing triple-backtick code blocks, but I think the average person reading "supports Github-flavored markdown" is going to reasonably think that means it supports basically everything you can do with Markdown on Github, which would include emojis. If that's not the case it might be better to adjust the documentation so it more narrowly says something like "You can use triple backticks for code blocks (similar to Github)" rather than broadly saying that Github-flavored markdown is supported.

@tonyfast
Copy link
Collaborator

This is solved in JupyterLab and will be solved in the future Notebook v7 release.

For more information about this new release, checkout the Notebook v7 Enhancement Proposal.

@JasonWeill
Copy link
Collaborator

To clarify, JupyterLab supports literal emoji (e.g., with CMD+CTRL+SPACE on macOS or with WIN+PERIOD on Windows 10+) but not the shortcut codes that some editors support (e.g., :heart: for ❤️). This is by design.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants