Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove IPYTHON_ALLOW_DRAFT_WEBSOCKETS_FOR_PHANTOMJS #2250

Closed
minrk opened this issue Mar 3, 2017 · 0 comments · Fixed by #2628
Closed

remove IPYTHON_ALLOW_DRAFT_WEBSOCKETS_FOR_PHANTOMJS #2250

minrk opened this issue Mar 3, 2017 · 0 comments · Fixed by #2628
Labels
status:resolved-locked
Milestone
5.1

Comments

@minrk
Copy link
Member

minrk commented Mar 3, 2017

with updates to phantomjs being based on Qt5 (v2.0, I think), we probably don't need to ship the backport to deprecated implementations of the websockets for the phantomjs tests.

I won't say we should do this for 5.0 since it's close to release, but I think we can drop this bit of testing code.
@minrk minrk added this to the 5.1 milestone Mar 3, 2017
takluyver added a commit to takluyver/notebook that referenced this issue Jul 4, 2017
@takluyver
Remove old websocket draft76 protocol.
724bdd1 
Support for this older protocol should no longer be needed with
Phantom JS 2.

Closes jupytergh-2250
@takluyver takluyver mentioned this issue Jul 4, 2017
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status:resolved-locked
Projects
None yet
Milestone
5.1
Development

Successfully merging a pull request may close this issue.

Remove old websocket draft76 protocol. takluyver/notebook
1 participant
@minrk