Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favicon symlink causing Windows problems #3215

Closed
takluyver opened this issue Jan 16, 2018 · 0 comments · Fixed by #3220
Closed

Favicon symlink causing Windows problems #3215

takluyver opened this issue Jan 16, 2018 · 0 comments · Fixed by #3220
Labels
status:resolved-locked
Milestone
5.4

Comments

@takluyver
Copy link
Member

notebook/static/favicon.ico is a symlink in the repository. Under at least some conditions, this causes issues on Windows:

    File "C:\Users\appveyor\AppData\Local\Temp\1\pip-le56htf7-build\setupbase.py", line 229, in check_package_data
      assert os.path.exists(path), "Missing package data: %s" % path
  AssertionError: Missing package data: notebook\static\favicon.ico

I'm not yet sure how common these conditions are. I'm trying to work around it on conda-forge.
takluyver added a commit to takluyver/notebook that referenced this issue Jan 16, 2018
@takluyver
Replace symlinked favicon with a copy
3b069e3 
Closes jupytergh-3215
@takluyver takluyver mentioned this issue Jan 16, 2018
Merged
@minrk minrk added this to the 5.4 milestone Jun 15, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status:resolved-locked
Projects
None yet
Milestone
5.4
Development

Successfully merging a pull request may close this issue.

Replace symlinked favicon with a copy takluyver/notebook
2 participants
@minrk @takluyver