Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: calling 'jupyter notebook' does not 'block' the command prompt #367

Closed
jorisvandenbossche opened this issue Aug 31, 2015 · 6 comments

Comments

@jorisvandenbossche
Copy link
Contributor

Don't know how to clearly specify this issue in the one line title, but I am seeing the following issue on Windows:

  • Open a command prompt
  • call jupyter notebook
  • the notebook starts correctly, no problem with that
  • but, you can still type in the command prompt; eg ls will list all files and dirs. So the command line is not 'blocked', it returns back to the prompt.

By itself, this seems not really a problem (everything works for the rest), but it is a) inconsistent with how it was before on Windows, b) inconsistent with how it is on eg linux and c) finally, can be a bit confusing (eg because it takes a few seconds before jupyter launches, the C:\Users\username> prompt already appears before there is any output of jupyter, giving the impression for a few seconds that it didn't work)

Using notebook 4.0.4, jupyter_client 4.0.0, jupyter_core 4.0.4, ipykernel 4.0.3, ipython 4.0.0

@Carreau
Copy link
Member

Carreau commented Aug 31, 2015

o_O I suppose Ctrl-C does not stop the notebook ?

@jorisvandenbossche
Copy link
Contributor Author

That still works! :-) (although not very clear it would ..)

As I said, everything seems to work correctly, but is just very strange ..

@Carreau Carreau added this to the 4.1 milestone Aug 31, 2015
@Carreau
Copy link
Member

Carreau commented Aug 31, 2015

indeed.

@juhasch
Copy link
Contributor

juhasch commented Sep 17, 2015

The reason is jupyter_core uses execvp() to launch subcommands. Replacing the call with subprocess.call().

This makes jupyter nbconvert annyoing and jupyter console unusable under Windows.

@damianavila
Copy link
Member

The reason is jupyter_core uses execvp() to launch subcommands.

This is no longer true, the fix was merged: jupyter/jupyter_core#54

@Carreau Carreau closed this as completed Sep 18, 2015
@juhasch
Copy link
Contributor

juhasch commented Sep 18, 2015

Great! Thanks.

@minrk minrk modified the milestones: 4.0.5, 4.1 Sep 18, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants