don't use exec on Windows #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it doesn't exec, it does fork & exec, which means the parent process returns immediately, and the 'true' process is put in the background. Windows doesn't actually allow process replacement.
set handler after spawning subprocess so it is still forwarded.
|
Confirmed working on Windows. |
|
Link to proof that |
|
Thanks, @sccolbert! |
|
I guess that also fixes jupyter/nbconvert#103 ? |
Hah, yes already closed. The page was still opened for me and did not refresh correctly. Thanks. |
|
This also fixes jupyter console on windows: jupyter/jupyter_console#26 (based on a quick test it seems fixed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use regular Popen instead.
Windows doesn't actually allow process replacement a la unix exec, but Python provides os.exec on Windows even though it doesn't actually work. It doesn't exec, it does fork & exec, which means the parent process returns immediately, and the 'true' process is put in the background.
The alternative is to use execfile on Windows, which would behave the same as exec on *ix, with one exception: it forces all jupyter commands to be run with the same interpreter, rather than respecting shebang lines.
closes jupyter/nbconvert#103