Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter Notebook is broken in Firefox #4500

Open
edumorales97 opened this issue Mar 20, 2019 · 6 comments

Comments

Projects
None yet
7 participants
@edumorales97
Copy link

commented Mar 20, 2019

Screen Shot 2019-03-20 at 12 53 44 AM

When I run 'jupyter notebook' it will open the html file in the filesystem and will be displayed incorrectly in the Firefox 67 and 68 (current Betas, I haven't tested 66). This issue does not happen in Chrome or Safari.
file:///Users/eduardomorales/Library/Jupyter/runtime/nbserver-81921-open.html

The only way to fix this is to access the URL provided in the terminal instead.
http://localhost:8888/?token=57035d2f78d7578f424d28e280855612e6d4b6cfb73f5de7

@fxthomas

This comment has been minimized.

Copy link

commented Mar 22, 2019

Seems to be an issue with the most recent release. Using an older release works:

pip install notebook==5.6.0
@kfrncs

This comment has been minimized.

Copy link

commented Apr 9, 2019

thank you! this fixed it. This is the third thread I found about this issue, btw.

@lead0r

This comment has been minimized.

Copy link

commented Apr 9, 2019

I also have the same problem, only in Firefox. I don't think using an older version of notebook is a fix, though.

Does anyone know why this happens?

@skagr

This comment has been minimized.

Copy link

commented Apr 14, 2019

Confirmed not working on Firefox 67 (MacOS Mojave)

Cause is this commit, which changed the way Jupyter Notebook is opened in the browser:
270c0f9#diff-f68f5eab41b9092b5b739944f53d5730

Instead of opening <base-url>/?token=<token> directly, an nbserver-<pid>-open.html file is now created which redirects to <base-url>/tree?token=<token>

Safari and Chrome have no problems with this redirect, but Firefox does. I have edited the nbserver-<pid>-open.html file to remove the tree part and can confirm that this does work in Firefox.

By the way: this same problem exists in jupyter lab

@0n0n0m0uz

This comment has been minimized.

Copy link

commented Apr 19, 2019

the nbserver--open.html is generated new each time the notebook is run so editing the html file only works for a few hours. What exactly is it about firefox that it can't handle the redirect? I was trying to tweak the code directly(open_url, default_url?) but spent hours for such a stupid little fix. At some point the /tree is needed but just not in the final html file creation. I am a newbie so this was definitely learning opp for me. I am following along on my own machine.

@Josephat-n

This comment has been minimized.

Copy link

commented May 17, 2019

Seems to be an issue with the most recent release. Using an older release works:

pip install notebook==5.6.0

This solved my issue too, after spending much time diagnosing and attempting several options in vain!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.