New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tests to py.test #4753
Comments
An additional step would be to remove the Also nose has not been actively developed for a while, from their website
|
Personally, I'd vote for new tests to be written that way if they can, but it might not be worth the effort to migrate a large and complicated test base to it. |
I think part of the challenge with that is that without fixtures already in place for some of the functionality, it becomes hard to even write new test without needing to rebuild the entire underlying infrastructure. One thought: It might make sense to take one existing test that we think will require making the appropriate fixtures and then migrate that & create those fixtures, so that new tests can build upon that basis. |
Given nose is going to be incompatible with upcoming version of Python (certainly 3.10), here is the patch we use in OpenSUSE to eliminate the dependency. |
Currently most of
notebook/tests
(except the selenium ones) are all using the built-inunittest
module. Native pytest format tests (with just functions) feels more readable and better adopted now. We also use it a lot in other parts of the ecosystem.How do people feel about moving?
The text was updated successfully, but these errors were encountered: