Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not require nose for testing #5826

Merged
merged 6 commits into from Oct 29, 2020
Merged

do not require nose for testing #5826

merged 6 commits into from Oct 29, 2020

Conversation

pgajdos
Copy link
Contributor

@pgajdos pgajdos commented Oct 22, 2020

nose is deprecated and will not work in future python versions.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good - thank you! Only had the one comment regarding the print statements.

@@ -16,7 +15,9 @@ def test_path_regex():
'/x/foo/bar',
'/x/foo/bar.txt',
):
assert_regex(path, path_pat)
print(type(path))
print(type(path_pat))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably remove these print statements.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pgajdos.

@kevin-bates kevin-bates merged commit 7221718 into jupyter:master Oct 29, 2020
@hroncok
Copy link
Contributor

hroncok commented Jan 7, 2021

@kevin-bates
Copy link
Member

Good catch @hroncok - thanks. Looks like the updates to notebook/tests/test_notebookapp_integration.py were missed. Any idea how nose is getting into the CI? I'm not seeing anything immediately, but it's definitely present in the pip freeze output.

At any rate, PR forthcoming to address the remaining references that pull in nose.

@hroncok
Copy link
Contributor

hroncok commented Jan 8, 2021

AFAIK nose comes pre-installed in Travis Python environments (I guess historically this was a good idea, not sure).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants