do not require nose for testing #5826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zsailer
approved these changes
Oct 26, 2020
kevin-bates
reviewed
Oct 27, 2020
notebook/tests/test_paths.py
Outdated
| @@ -16,7 +15,9 @@ def test_path_regex(): | |||
| '/x/foo/bar', | |||
| '/x/foo/bar.txt', | |||
| ): | |||
| assert_regex(path, path_pat) | |||
| print(type(path)) | |||
| print(type(path_pat)) | |||
There was a problem hiding this comment.
We should probably remove these print statements.
|
Note that nose appears still required via https://github.com/ipython/ipython_genutils/blob/fbcb174d06d6df1f8633014dd80fad8c45533c2e/ipython_genutils/testing/decorators.py#L162 |
|
Good catch @hroncok - thanks. Looks like the updates to At any rate, PR forthcoming to address the remaining references that pull in |
|
AFAIK nose comes pre-installed in Travis Python environments (I guess historically this was a good idea, not sure). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noseis deprecated and will not work in future python versions.