Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port bugfix from jupyter_server #6281

Closed
kycutler opened this issue Jan 26, 2022 · 3 comments · Fixed by #6290
Closed

Port bugfix from jupyter_server #6281

kycutler opened this issue Jan 26, 2022 · 3 comments · Fixed by #6290

Comments

@kycutler
Copy link
Contributor

jupyter-server/jupyter_server#628 fixed an issue in jupyter_server, but was never ported over to the notebook backend. I'm not sure what the standard procedure here is, so I'm opening this issue to hopefully get the ball rolling as this would be great to have fixed in both backends if possible.

@JasonWeill
Copy link
Collaborator

@blink1073 made the change in jupyter-server/jupyter_server#628 — should this be ported into this package as well?

@blink1073
Copy link
Member

I think so, but you'd also need jupyter-server/jupyter_server#636 to account for kernels that don't expect that message on the control channel.

@kycutler
Copy link
Contributor Author

@blink1073 Would you mind reviewing the PR I opened to close this?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants