Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help > About Jupyter launches web site in new tab #6782

Open
JasonWeill opened this issue Mar 22, 2023 · 4 comments
Open

Help > About Jupyter launches web site in new tab #6782

JasonWeill opened this issue Mar 22, 2023 · 4 comments
Assignees
Labels
Milestone

Comments

@JasonWeill
Copy link
Collaborator

Help > About Jupyter launches https://jupyter.org in a new tab. It should instead display a modal dialog, like Help > About Jupyter Notebook does.

This was found during a bug bash by @andrii-i.

@JasonWeill JasonWeill added the bug label Mar 22, 2023
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Mar 22, 2023
@jtpio
Copy link
Member

jtpio commented Mar 22, 2023

Maybe we should remove this menu entry?

JupyterLab does not seem to have it:

image

And the classic notebook redirects to help and external documentation:

image

@andrii-i
Copy link
Contributor

@jtpio Do you mean deleting "About" menu entry from Notebook?

Notebook has "About" menu entry that leads to https://jupyter.org and JupyterLab has similar "About JupyterLab" entry that shows informational popup like below. Point of that issue is that Notebook "About" menu item should not lead to the https://jupyter.org and should show informational popup like in JupyterLab / below:
image

@jtpio
Copy link
Member

jtpio commented Mar 22, 2023

Help > About Jupyter launches https://jupyter.org in a new tab

I meant this one, which corresponds to the comment above:

image

@RRosio RRosio removed the status:Needs Triage Applied to issues that need triage label Mar 28, 2023
@RRosio RRosio added this to the 7.0 milestone Mar 28, 2023
@andrii-i
Copy link
Contributor

Adding an icon signifying that there would be a tab opened on click would solve the problem

@andrii-i andrii-i modified the milestones: 7.0, 7.0.x Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants