Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to checkpoints every 2s #6995

Open
germandb opened this issue Aug 1, 2023 · 1 comment
Open

Call to checkpoints every 2s #6995

germandb opened this issue Aug 1, 2023 · 1 comment
Labels
Milestone

Comments

@germandb
Copy link

germandb commented Aug 1, 2023

Description

Hi, I'm trying notebook 7 and encounter that when I open a notebook every 2 seconds, a call like this http://localhost:10000/api/contents/work/test.ipynb/checkpoints?1690882333842 is made to the checkpoints endpoint.
The notebook is not actually saved, and no checkpoint gets created.
This doesn't happen when you open the same notebook with Jupyterlab.
The network tab in dev tools with notebook 7
image
the same info with Jupyterlab
image

Reproduce

Use docker run -p 10000:8888 jupyter/base-notebook:notebook-7.0.0 for start a new jupyter server
go to http://localhost:10000/tree
create a new notebook
open the network tab
the calls to checkpoints start to appear

Expected behavior

That works like in Jupyterlab, only the sessions and kernels calls are made

Context

  • Docker image jupyter/base-notebook:notebook-7.0.0
  • Browser: Edge Versión 115.0.1901.188
Troubleshoot Output
Paste the output from running `jupyter troubleshoot` from the command line here.
You may want to sanitize the paths in the output.
Command Line Output
Paste the output from your command line running `jupyter notebook` here, use `--debug` if possible.
Browser Output
Paste the output from your browser Javascript console here, if applicable.
@germandb germandb added bug status:Needs Triage Applied to issues that need triage labels Aug 1, 2023
@jtpio
Copy link
Member

jtpio commented Aug 1, 2023

Thanks @germandb for catching this 👍

The checkpoint polling is implemented here in Notebook 7:

new Poll({
auto: true,
factory: () => onChange(),
frequency: {
interval: 2000,
backoff: false,
},
standby: 'when-hidden',
});

This is used to update the checkpoint indicator in the top area:

image

That works like in Jupyterlab, only the sessions and kernels calls are made

Otherwise maybe we could increase the interval?

@jtpio jtpio added this to the 7.0.x milestone Aug 1, 2023
@RRosio RRosio removed the status:Needs Triage Applied to issues that need triage label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants