Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing lint check with the latest traitlets #7081

Closed
jtpio opened this issue Oct 2, 2023 · 0 comments · Fixed by #7082
Closed

Failing lint check with the latest traitlets #7081

jtpio opened this issue Oct 2, 2023 · 0 comments · Fixed by #7082
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Oct 2, 2023

Looks like the latest traitlets causes the lint check to fail on CI:

https://github.com/jupyter/notebook/actions/runs/6377215958/job/17305469073?pr=7080

notebook/app.py:256: error: Incompatible types in assignment (expression has type "Dict[str, Any]", base class "Application" defined the type as "Dict[Union[str, Tuple[str, ...]], Tuple[Union[Dict[str, Any], Config], str]]")  [assignment]
notebook/app.py:257: error: Cannot determine type of "flags"  [has-type]
notebook/app.py:262: error: Cannot determine type of "flags"  [has-type]
notebook/app.py:267: error: Unused "type: ignore" comment  [unused-ignore]
notebook/app.py:271: error: Unused "type: ignore" comment  [unused-ignore]
notebook/app.py:275: error: Unused "type: ignore" comment  [unused-ignore]
notebook/app.py:279: error: Unused "type: ignore" comment  [unused-ignore]
notebook/app.py:283: error: Unused "type: ignore" comment  [unused-ignore]
notebook/app.py:287: error: Unused "type: ignore" comment  [unused-ignore]
notebook/app.py:291: error: Unused "type: ignore" comment  [unused-ignore]

This might be related to ipython/traitlets#868.

@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Oct 2, 2023
@jtpio jtpio added this to the 7.0.x milestone Oct 2, 2023
@jtpio jtpio removed the status:Needs Triage Applied to issues that need triage label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant