Fix traitlets typing - #7082
Merged
Merged
Conversation
Contributor
|
|
jtpio
commented
Oct 2, 2023
|
|
||
| HERE = os.path.dirname(__file__) | ||
|
|
||
| Flags = t.Dict[t.Union[str, t.Tuple[str, ...]], t.Tuple[t.Union[t.Dict[str, t.Any], Config], str]] |
Member
Author
There was a problem hiding this comment.
cc @blink1073
Wondering if there would be a better / simpler way to handle this in downstream apps?
Contributor
There was a problem hiding this comment.
I'm working on making them just dict[str, Any] in Application and JupyterApp, rather than trying to be more specific. https://github.com/ipython/traitlets/pull/873/files#diff-5453d413070d06bcf7ba7f017b9cf364e774627fad69964a6471449e5c16dc37R371
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7081