Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable names are not changed for their values #7338

Open
shirounanashi opened this issue Apr 22, 2024 · 2 comments
Open

Variable names are not changed for their values #7338

shirounanashi opened this issue Apr 22, 2024 · 2 comments
Labels
bug status:Needs Info status:Needs Triage Applied to issues that need triage

Comments

@shirounanashi
Copy link

shirounanashi commented Apr 22, 2024

Description

Variable names are not changed for their values ​​when using a variable as an argument to a Python script

Reproduce

  1. Place an audio file (MP3, WAV or FLAC) in the "Input" folder
  2. Run this notebook: https://github.com/shirounanashi/test/blob/main/jupyter_bug.ipynb
  3. Or this: https://colab.research.google.com/drive/1Pyud6bWtUAic_xdE2TGVHAmfk6OAMwKS

Expected behavior

The name of the variable will be replaced by its value

Context

  • Operating System and version: Windows 11 and Google Colab
  • Browser and version: Microsoft Edge (Latest Version in 22/04/24), VS Code
  • Jupyter Notebook version: 7.1.3
Notebook Output
usage: main.py infer [-h]
                     [--f0up_key {-24,-23,-22,-21,-20,-19,-18,-17,-16,-15,-14,-13,-12,-11,-10,-9,-8,-7,-6,-5,-4,-3,-2,-1,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24}]
                     [--filter_radius {0,1,2,3,4,5,6,7,8,9,10}]
                     [--index_rate {0.0,0.1,0.2,0.3,0.4,0.5,0.6,0.7,0.8,0.9,1.0}]
                     [--rms_mix_rate {0.0,0.1,0.2,0.3,0.4,0.5,0.6,0.7,0.8,0.9,1.0}]
                     [--protect {0.0,0.1,0.2,0.3,0.4,0.5}]
                     [--hop_length {1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,98,99,100,101,102,103,104,105,106,107,108,109,110,111,112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127,128,129,130,131,132,133,134,135,136,137,138,139,140,141,142,143,144,145,146,147,148,149,150,151,152,153,154,155,156,157,158,159,160,161,162,163,164,165,166,167,168,169,170,171,172,173,174,175,176,177,178,179,180,181,182,183,184,185,186,187,188,189,190,191,192,193,194,195,196,197,198,199,200,201,202,203,204,205,206,207,208,209,210,211,212,213,214,215,216,217,218,219,220,221,222,223,224,225,226,227,228,229,230,231,232,233,234,235,236,237,238,239,240,241,242,243,244,245,246,247,248,249,250,251,252,253,254,255,256,257,258,259,260,261,262,263,264,265,266,267,268,269,270,271,272,273,274,275,276,277,278,279,280,281,282,283,284,285,286,287,288,289,290,291,292,293,294,295,296,297,298,299,300,301,302,303,304,305,306,307,308,309,310,311,312,313,314,315,316,317,318,319,320,321,322,323,324,325,326,327,328,329,330,331,332,333,334,335,336,337,338,339,340,341,342,343,344,345,346,347,348,349,350,351,352,353,354,355,356,357,358,359,360,361,362,363,364,365,366,367,368,369,370,371,372,373,374,375,376,377,378,379,380,381,382,383,384,385,386,387,388,389,390,391,392,393,394,395,396,397,398,399,400,401,402,403,404,405,406,407,408,409,410,411,412,413,414,415,416,417,418,419,420,421,422,423,424,425,426,427,428,429,430,431,432,433,434,435,436,437,438,439,440,441,442,443,444,445,446,447,448,449,450,451,452,453,454,455,456,457,458,459,460,461,462,463,464,465,466,467,468,469,470,471,472,473,474,475,476,477,478,479,480,481,482,483,484,485,486,487,488,489,490,491,492,493,494,495,496,497,498,499,500,501,502,503,504,505,506,507,508,509,510,511,512}]
                     [--f0method {pm,harvest,dio,crepe,crepe-tiny,rmvpe,fcpe,hybrid[crepe+rmvpe],hybrid[crepe+fcpe],hybrid[rmvpe+fcpe],hybrid[crepe+rmvpe+fcpe]}]
                     [--input_path INPUT_PATH] [--output_path OUTPUT_PATH]
                     [--pth_path PTH_PATH] [--index_path INDEX_PATH]
                     [--split_audio {True,False}] [--f0autotune {True,False}]
                     [--clean_audio {True,False}]
                     [--clean_strength {0.0,0.1,0.2,0.3,0.4,0.5,0.6,0.7,0.8,0.9,1.0}]
                     [--export_format {WAV,MP3,FLAC,OGG,M4A}]
main.py infer: error: argument --f0up_key: invalid choice: '{pitch}' (choose from '-24', '-23', '-22', '-21', '-20', '-19', '-18', '-17', '-16', '-15', '-14', '-13', '-12', '-11', '-10', '-9', '-8', '-7', '-6', '-5', '-4', '-3', '-2', '-1', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '10', '11', '12', '13', '14', '15', '16', '17', '18', '19', '20', '21', '22', '23', '24')
@shirounanashi shirounanashi added bug status:Needs Triage Applied to issues that need triage labels Apr 22, 2024
@RRosio
Copy link
Collaborator

RRosio commented Apr 23, 2024

Hi @shirounanashi, thank you for opening this issue, can you verify that this code snippet works when ran as a python script? Can you add a check to compare the value entered against the values in the list? The error message:

main.py infer: error: argument --f0up_key: invalid choice: '{pitch}' (choose from '-24', '-23', '-22', '-21', '-20', '-19', '-18', '-17', '-16', '-15', '-14', '-13', '-12', '-11', '-10', '-9', '-8', '-7', '-6', '-5', '-4', '-3', '-2', '-1', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '10', '11', '12', '13', '14', '15', '16', '17', '18', '19', '20', '21', '22', '23', '24')

lists string values while pitch is set to the integer zero pitch = 0 does making the pitch value a string change the output?

@shirounanashi
Copy link
Author

Hi @RRosio , I changed it to pitch="0" and got the same output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug status:Needs Info status:Needs Triage Applied to issues that need triage
Projects
None yet
Development

No branches or pull requests

2 participants