Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirection Screen Should Match theme #7390

Open
Michael13435 opened this issue Jun 4, 2024 · 3 comments
Open

Redirection Screen Should Match theme #7390

Michael13435 opened this issue Jun 4, 2024 · 3 comments
Labels

Comments

@Michael13435
Copy link

Problem

Redirection screen that directs to jupyter is always white, regardless of system, browser, or jupyter theme

Proposed Solution

Jupyter's redirection screen should preferably match the browser, or the theme chosen for Jupyter if the former is not possible

@Michael13435 Michael13435 added enhancement status:Needs Triage Applied to issues that need triage labels Jun 4, 2024
@RRosio RRosio added bug and removed enhancement status:Needs Triage Applied to issues that need triage labels Jun 4, 2024
@RRosio
Copy link
Collaborator

RRosio commented Jun 4, 2024

@Michael13435 thank you for reporting this! Could you share which version of Notebook you are using?

@JasonWeill does see a flash of white when using Notebook 7 in Dark Mode.

From @krassowski,

const splash: JupyterFrontEndPlugin<ISplashScreen> = {
id: '@jupyter-notebook/application-extension:splash',
description: 'Provides an empty splash screen.',
autoStart: true,
provides: ISplashScreen,
activate: (app: JupyterFrontEnd) => {
const { restored } = app;
const splash = document.createElement('div');
splash.style.position = 'absolute';
splash.style.width = '100%';
splash.style.height = '100%';
splash.style.zIndex = '10';
return {
show: (light = true) => {
splash.style.backgroundColor = light ? 'white' : '#111111';
document.body.appendChild(splash);
return new DisposableDelegate(async () => {
await restored;
document.body.removeChild(splash);
});
},
};
},
};
, is the Notebook splash screen which should be covering the entire screen in a dark-gray color.

@Michael13435
Copy link
Author

@Michael13435 thank you for reporting this! Could you share which version of Notebook you are using?

@JasonWeill does see a flash of white when using Notebook 7 in Dark Mode.

From @krassowski,

const splash: JupyterFrontEndPlugin<ISplashScreen> = {
id: '@jupyter-notebook/application-extension:splash',
description: 'Provides an empty splash screen.',
autoStart: true,
provides: ISplashScreen,
activate: (app: JupyterFrontEnd) => {
const { restored } = app;
const splash = document.createElement('div');
splash.style.position = 'absolute';
splash.style.width = '100%';
splash.style.height = '100%';
splash.style.zIndex = '10';
return {
show: (light = true) => {
splash.style.backgroundColor = light ? 'white' : '#111111';
document.body.appendChild(splash);
return new DisposableDelegate(async () => {
await restored;
document.body.removeChild(splash);
});
},
};
},
};

, is the Notebook splash screen which should be covering the entire screen in a dark-gray color.

I saw this behaviour on jupyter version 6.5.4

@JasonWeill
Copy link
Collaborator

@Michael13435 Thank you for your response! Notebook 6 is now maintained as nbclassic. I would recommend opening an issue in nbclassic if you intend to keep using Notebook 6; otherwise, we will fix this in Notebook 7 in this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants