only consider stream output for data rate limit #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
large stream outputs cause much more problems than image output this does open up to large HTML and/or displayed text output, but those seem to behave well more often than they don't.
blink1073
approved these changes
Mar 15, 2017
|
This sounds like a good solution. Thanks so much for the quick response! |
|
It just occurred to me that this was slated for 5.1 and I merged it on to master. Is this ok or do I need to revert it? |
|
I think we should probably revert it, or make a |
|
Reverting's probably easiest for now. |
|
This was reverted in #2326, so it will need to be repeated for 5.1. |
|
Thank you, my apologies. Glad this PR was made. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
large stream outputs cause much more problems than images or binary widget data, which seem to hit the rate limit more than anything.
this does open us up to large HTML and/or displayed text output potentially causing issues,
but most large outputs that have been hitting this limit do not cause issues (#2287).
The main throttle that's important is DOM elements to be added to the page. We can't feasibly distinguish between a massive million-element SVG and HTML with one big image in it.
This does explicitly remove the ability to do throttling based on bandwith. If people do want that, I can add the stream limit to a new config value. In that case, I would change the default all-output rate limit to no limit, so the same behavior as this PR, just with an extra knob.
closes #2287