Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow session of type other than notebook. #2559

merged 1 commit into from Jun 8, 2017


Copy link

The notebook server session API now allows session for things other than notebooks (consoles, etc.). However, the frontend was assuming a notebook type. This was causing problems when jupyterlab had consoles running. This adds a test to make sure the classic notebook only deals with notebook sessions.

This will need to be backported into a 5.x bug fix release for the JupyterLab beta.


Copy link
Contributor Author

Fixes jupyterlab/jupyterlab#2389

@minrk minrk merged commit 65f7226 into jupyter:master Jun 8, 2017
Copy link

minrk commented Jun 8, 2017

Probably doesn't need backport, as I think 5.1 will be released from master (no breaking changes yet).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants