Allow session of type other than notebook. #2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
approved these changes
Jun 8, 2017
|
Probably doesn't need backport, as I think 5.1 will be released from master (no breaking changes yet). |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notebook server session API now allows session for things other than notebooks (consoles, etc.). However, the frontend was assuming a notebook type. This was causing problems when jupyterlab had consoles running. This adds a test to make sure the classic notebook only deals with notebook sessions.
This will need to be backported into a 5.x bug fix release for the JupyterLab beta.
@gnestor