fix notebook require config to match tools/build-main #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as otherwise, any template based on page will fail to load unless it already has its own minified js including the dependencies
rgbkrk
approved these changes
Oct 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2140 altered the dependencies of a bunch of modules, without updating the require config used on page.html template. The updated tools/build-main.js require config ensures that this isn't a problem for pages with built minified js, but the changes currently break any extension template which tries to load affected modules.
This only goes partway to fixing this, since the final thing I haven't figured out how to fix correctly is
nbjs.json, which unfortunately sits below the server-rootstaticdirectory (d'oh!) so can be loaded by the minifier build, but not by requirejs in an extension-templated page. Not sure what the best approach to fix that would be - I'd go for moving it into the static directory, but don't know enough (anything!) about the i18n mechanics to know whether that might cause other problems. Any thoughts appreciated - @JCEmmons I guess you're the most appropriate to ask about the i18n stuff?