Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The root directory of the notebook server should never be hidden #2907

Merged
merged 2 commits into from
Oct 6, 2017
Merged

The root directory of the notebook server should never be hidden #2907

merged 2 commits into from
Oct 6, 2017

Conversation

takluyver
Copy link
Member

Closes gh-2382

@takluyver takluyver added this to the 5.2 milestone Oct 6, 2017
@takluyver takluyver mentioned this pull request Oct 6, 2017
Closed
@choldgraf
Copy link
Contributor

TYVM @takluyver :-)

@gnestor
Copy link
Contributor

gnestor commented Oct 6, 2017

Tests are passing, shall I merge @takluyver?

@takluyver
Copy link
Member Author

I think it's OK. I saw you talking about releasing 5.2, so I thought I'd try to get this in.

@gnestor
Copy link
Contributor

gnestor commented Oct 6, 2017

Yes, after reading the whole discussion at #2382, I'm very grateful for this 🙏

@gnestor gnestor merged commit 12592ef into jupyter:master Oct 6, 2017
@takluyver takluyver deleted the i2382 branch October 6, 2017 17:49
@gnestor gnestor modified the milestone: 5.2 Oct 13, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gnestor gnestor gnestor approved these changes

Assignees
No one assigned
Labels
status:resolved-locked
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

404 error when starting notebook from a hidden folder
3 participants
@takluyver @choldgraf @gnestor