New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn_bad_name should not use global name #3160

Merged

takluyver merged 1 commit into jupyter:master from Sukneet:get_name-warn-fix

Dec 22, 2017

Contributor

Sukneet commented Dec 21, 2017

warn_bad_name in get_name should use the local variable name_or_data not name


          warn_bad_name should not use global name

ca5e39a

warn_bad_name in get_name should use the local variable name_or_data not name

takluyver added this to the 5.3 milestone

takluyver merged commit 3857c92 into jupyter:master

Member

takluyver commented Dec 22, 2017

Thanks, good catch!

pyup-bot mentioned this pull request

Update notebook to 5.4.0 openeemeter/eemeter#165

Closed

github-actions bot added the status:resolved-locked label

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.