Fix clearing two cookies with the same name #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
reviewed
Jan 15, 2018
notebook/base/handlers.py
Outdated
| if path and path != '/': | ||
| # also clear cookie on / to ensure old cookies | ||
| # are cleared after the change in path behavior. | ||
| self.clear_cookie(self.cookie_name) | ||
| self.force_clear_cookie(self.cookie_name) |
There was a problem hiding this comment.
Maybe just call the force_clear_cookie here so we are using the normal clear_cookie most of the time? And add a FIXME noting that this is a backward-compatibily bit added in 5.2?
|
I'm going to slip this into 5.3. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an ugly workaround, and it might go wrong other code tries to manipulate the same cookies for the same response. But at least in my testing, it fixes the issue reported in #3196 .
I think a properly robust fix would involve replacing
http.cookies.BaseCookiewith something that can handle multiple cookies with the same name. But Tornado appears to consider it a corner case that's not worth supporting (tornadoweb/tornado#1248), and it seems like a lot of work for us to build that just to tackle this one bug. Then again, it is a security bug, so maybe we should be taking that time.cc @minrk .
Closes gh-3196