Patch out bootstrap rule forcing black and white printing #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failures on Travis appear to be genuine failures from nbval. I just released 0.8, which catches some discrepancies that earlier versions of nbval missed. CC @vidartf . |
Carreau
approved these changes
Jan 17, 2018
damianavila
approved these changes
Jan 21, 2018
damianavila
reviewed
Jan 21, 2018
| rmed = lines.pop(ix) | ||
| print("Removed line", ix, "from bootstrap print.less:") | ||
| print("-", rmed) | ||
| print() |
There was a problem hiding this comment.
It makes a blank line, so the text above is slightly easier to pick out.
damianavila
reviewed
Jan 21, 2018
| lines = f.readlines() | ||
|
|
||
| for ix, line in enumerate(lines): | ||
| if 'Black prints faster' in line: |
There was a problem hiding this comment.
I guess this is enough specific to patch the proper line, right?
There was a problem hiding this comment.
Should be. The original file is not very long:
https://github.com/twbs/bootstrap/blob/v3.3.7/less/print.less
|
Thanks both ! |
|
@mpacer @takluyver, we need to update the css in the CDN so nbconvert can catch this change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A thoroughly ugly hack. Bootstrap forces all text to be black when printing, resulting in a long running issue (#840). I tried to override it with
color: inherit !important, but that didn't produce the right results. I can't find any way to tell LESS to remove a rule or act as if it didn't exist. So the only thing I can think to do is to patch the source we get from bootstrap to get rid of the rule entirely.Frustratingly, it looks like bootstrap is fixing this (getting rid of the rule) for v4, but it's also moving from LESS to SCSS, so we can't easily switch to the new version.
Closes gh-840