Add any extra installed nbconvert exporters to the "Download as" menu #3323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
reviewed
Feb 9, 2018
notebook/templates/notebook.html
Outdated
| <li id="download_{{ exporter.name }}"> | ||
| <a href="#">{{ exporter.display }}</a> | ||
| </li> | ||
| </span> |
|
Thanks! |
|
Thanks for the merge. Just a heads up (in case it was missed): jupyter/nbconvert#759 documents this feature over in |
|
Thanks for the heads up, I had missed that connection. I think the way you've documented it makes sense. :-) |
This was referenced May 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice if extra
nbconvertexporters show up on the "File -> Download as" menu, without the need to write a custom Javascript extension.Of course, some exporters will have required parameters, so this system is opt-in -- the exporter must define the
export_from_notebookmenu to provide a friendly (and possibly translatable) name to the menu.