add settings['activity_sources'] #3401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for extensions to register activity that should prevent shutdown due to inactivity
takluyver
reviewed
Mar 7, 2018
notebook/notebookapp.py
Outdated
| @@ -264,6 +264,8 @@ def init_settings(self, jupyter_app, kernel_manager, contents_manager, | |||
|
|
|||
| # Jupyter stuff | |||
| started=now, | |||
| # place for extensions to register activity | |||
| activity_sources={}, | |||
There was a problem hiding this comment.
'sources' suggests to me that it contains something like functions you call to get activity timestamps. Maybe call it something like last_activity_times?
There was a problem hiding this comment.
Ping @minrk . I can do the name change if you're OK with it.
There was a problem hiding this comment.
Sorry, just got back to it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for extensions to register activity that should prevent shutdown due to inactivity