Convert jstests to selenium: deletecell.js #3465
Conversation
…n changes in PR jupyter#3475. This should be update once that PR is merged
sheshtawy
changed the title
| notebook.current_cell.send_keys('dd') | ||
|
|
||
| def test_delete_cells(notebook): | ||
| print('testing deleteable cells') |
There was a problem hiding this comment.
We shouldn't need this print() - pytest should tell us which test is which when it runs them.
|
Thanks, it looks like the tests are passing now. Are you satisfied that you've converted the whole of |
Update to use the updated notebook fixture
|
|
||
| @pytest.fixture | ||
| def notebook(authenticated_browser): | ||
| return Notebook.new_notebook(authenticated_browser) | ||
|
|
||
| def get_cells_contents(nb): |
There was a problem hiding this comment.
@takluyver Thanks for taking the time to review my PR. I made some changes to address your comments. I have only one more idea that I'm not sure about and I would like your input. I was thinking of moving this function to the Notebook class since I think it might be needed/repeated in several tests. I'm not sure about other helper functions like delete_cell, cell_is_deletable and set_cell_metadata, do you think they also should be moved to the Notebook class too?
There was a problem hiding this comment.
I'd say that the get_cells_contents and set_cell_metadata can move to the notebook class, but let's leave delete_cell and cell_is_deletable here for now. They can always be moved in another PR if we change our minds. :-)
There was a problem hiding this comment.
I made the changes. I believe the PR is ready to be merged if you don't have any more comments :)
…n changes in PR jupyter#3475. This should be update once that PR is merged
Update to use the updated notebook fixture
…eshtawy/notebook into convert-jstest-to-selenium-deletecell
|
Thanks! |
This PR is related to #3335. It's mean to convert the file
deletecell.jsinto a selenium test.