Add find replace test #3630
Add find replace test #3630
Conversation
notebook/tests/selenium/utils.py
Outdated
| def esc(browser, k): | ||
| """Send key combination esc+(k)""" | ||
| ActionChains(browser)\ | ||
| .key_down(Keys.ESCAPE).send_keys(k).key_up(Keys.ESCAPE).perform() |
There was a problem hiding this comment.
This isn't necessary - Esc isn't used as a modifier key that you have to hold down while pressing other keys. Just call self.to_command_mode() and then send the other keys as normal.
There was a problem hiding this comment.
I see okay. Makes sense, will call self.to_command_mode()
notebook/tests/selenium/utils.py
Outdated
| def find_and_replace(self, index=0, find_txt='', replace_txt='', replace_all=False): | ||
| self.focus_cell(index) | ||
| esc(self.browser, 'F') | ||
| time.sleep(1) # TODO: find better way to fill the find and replace form |
There was a problem hiding this comment.
Are there any specific elements on the form? We can wait for an element to appear.
There was a problem hiding this comment.
Hmm, I don't want to comment now before trying again (I rem trying the wait logic while working on this, but couldn't get the wait working because I couldn't find any specific element, but let me retry)
notebook/tests/selenium/utils.py
Outdated
| esc(self.browser, 'F') | ||
| time.sleep(1) # TODO: find better way to fill the find and replace form | ||
| self.browser.find_elements_by_css_selector("button.btn.btn-default.btn-sm")[2].click() | ||
| JS = "document.getElementsByClassName('form-control input-sm')[0].setAttribute('value', '%s')"%find_txt |
There was a problem hiding this comment.
We shouldn't need to construct JS just to set the value of a form field like this, I think.
There was a problem hiding this comment.
right, let me see how I can make it better.
notebook/tests/selenium/utils.py
Outdated
| self.focus_cell(index) | ||
| esc(self.browser, 'F') | ||
| time.sleep(1) # TODO: find better way to fill the find and replace form | ||
| self.browser.find_elements_by_css_selector("button.btn.btn-default.btn-sm")[2].click() |
There was a problem hiding this comment.
This code is basically for clicking double "upside down" arrow (third button) on the find and replace form to enable global replace. It's kinda hacky way of doing it, since the buttons don't have any specific ids on them which made it harder to fetch them directly. But let me will revisit this commit to see if we can make it more robust. Thanks !
There was a problem hiding this comment.
We could add an ID, so long as that's not going to cause problems. If you do, try closing and reopening the dialog a few times so it's created several successive buttons with the same ID, and check that the button still works.
|
Thanks, added 'ids' in the find_and_replace form. Code looks much clearer now. |
| @@ -163,6 +163,7 @@ define([ | |||
|
|
|||
| var allCellsButton = $('<button/>') | |||
| .append($('<i/>').addClass('fa fa-arrows-v')) | |||
| .attr('id', 'allcells_id') | |||
There was a problem hiding this comment.
IDs don't need to have a _id suffix, but they do need to be unique on the whole page - that includes IDs that might come from extensions or from output produced in a notebook. So let's make them a bit more specific, like findreplace_allcells_btn - and likewise for the other ones added here.
notebook/tests/selenium/utils.py
Outdated
| @@ -100,6 +100,16 @@ def focus_cell(self, index=0): | |||
| self.to_command_mode() | |||
| self.current_cell = cell | |||
|
|
|||
| def find_and_replace(self, index=0, find_txt='', replace_txt='', replace_all=False): | |||
There was a problem hiding this comment.
Looks like the replace_all parameter doesn't do anything. It's fine to drop it for now - it can always be added back when there's a test that wants to use it.
| @@ -0,0 +1,25 @@ | |||
| import os | |||
There was a problem hiding this comment.
Let's call the file test_find_and_replace.py - we'll probably later want to add tests that aren't doing apply all.
|
It is looking much clearer :-) |
…me of the testcase as mentioned in the comments
|
Thanks for reviewing, renamed the ids, removed the replace_all parameter and changed the name of testcase. |
|
Thanks! |
Adding a selenium based test for finding and replacing in selected cell applied on all cells