add el & update css in output_area to match run button in input prompt from #3535 #3687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yter#3535 Without this change the output and Input areas become unaligned. This still isn't an ideal fix, but it'll make a release possible without making the styling problematic.
|
@takluyver @minrk @gnestor I don't think this is super controversial (in comparison to 3535), can I get an expedited review so that I can proceed with making a release candidate for 5.6? |
|
Alternatively to a expedited review, if we do want to iterate on this PR a bunch, I'd like to suggest reverting #3535 to make a 5.6 release candidate possible, pushing it until 5.7 (or 5.6.1) when we can figure out a better way to handle the styling issues. |
rgbkrk
approved these changes
Jun 14, 2018
|
Thanks @mpacer! Let me know how I can help with 5.6 efforts 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change the output and Input areas become unaligned.
This still isn't an ideal fix, but it'll make a release possible without making the styling problematic.
This can be seen as a styling continuation of #3535.