fix:can't choose same file twice when in upload file#3712
Merged
minrk merged 1 commit intojupyter:masterfrom Aug 1, 2018
Merged
fix:can't choose same file twice when in upload file#3712minrk merged 1 commit intojupyter:masterfrom
minrk merged 1 commit intojupyter:masterfrom
Conversation
Member
|
Have you tested the old and the new across different browsers? The old code must have worked for someone at some point, so I want to make sure we don't just go from one solution that works for some people to another that works for some other people. |
Contributor
Author
|
finally,I test it on safair(11.1), firfox(61),chrome(67).the old code dont't work on chrome, new code work on each browser |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear fileinput value. This is required to reset the form. Otherwise, if you upload a file, delete it and try to upload it again, the changed event won't fire.
the old, replacing fileinput did not work as expected