Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tornado max_body_size & max_buffer_size settings #3829

Merged
merged 3 commits into from Sep 13, 2018

Conversation

mociarain
Copy link
Contributor

@mociarain mociarain commented Aug 7, 2018

The limits for max_body_size and max_buffer_size weren't being correctly passed to the underlying http server. This PR fixes that, using the described defaults, nominally 512MB as opposed to the actual tornado defaults of 100MB, and makes the values configurable.

It solves the following related issues:

closes #3797 and #650

@lihan
Copy link

lihan commented Aug 14, 2018

+1

1 similar comment
@dewaldabrie
Copy link

+1

@minrk
Copy link
Member

minrk commented Sep 13, 2018

Thank you!

@minrk minrk added this to the 5.7 milestone Sep 13, 2018
@minrk minrk merged commit f81ec30 into jupyter:master Sep 13, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting max_body_size for the underlying tornado server isn't working
4 participants