Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #4029: implement optional markdown header and footer files #4043

Merged
merged 2 commits into from
Jun 19, 2020
Merged

closes #4029: implement optional markdown header and footer files #4043

merged 2 commits into from
Jun 19, 2020

Conversation

reece
Copy link
Contributor

@reece reece commented Sep 27, 2018

I took a stab at implementing header and footer support from #4029. Comments appreciated. I'll add documentation to this PR after I get feedback that this change is welcomed.

$ jupyter notebook --debug docs/source/examples/Notebook/

selection_176

@Hyaxia
Copy link
Contributor

Hyaxia commented Sep 29, 2018

Hey, check #4039 for the fix for the tests that are failing.
Enjoy!

@blink1073 blink1073 added this to the 6.2 milestone Jun 8, 2020
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, apologies for the late review!

@kevin-bates kevin-bates merged commit 9fa644b into jupyter:master Jun 19, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants