Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch errors in app_initialized callbacks #424

Merged
merged 2 commits into from
Sep 14, 2015

Conversation

minrk
Copy link
Member

@minrk minrk commented Sep 14, 2015

avoids bad custom.js preventing initialization.

closes #415

rather than reimplementing with on/off.
avoids bad custom.js preventing initialization.
@ellisonbg
Copy link
Contributor

Hmm, travis looks grumpy with the js/tree tests on this...

On Mon, Sep 14, 2015 at 5:45 AM, Min RK notifications@github.com wrote:

avoids bad custom.js preventing initialization.

closes #415 #415

You can view, comment on, or merge this pull request online at:

#424
Commit Summary

  • use events.on for notebook first-load
  • catch errors in app_initialized callbacks

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#424.

Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
bgranger@calpoly.edu and ellisonbg@gmail.com

@Carreau
Copy link
Member

Carreau commented Sep 14, 2015

Grumpy travis seem to have missed his coffee this morning.
Relaunching tests.

@damianavila
Copy link
Member

ok, TravisCI took ☕ ... and code seem OK to me.

Carreau added a commit that referenced this pull request Sep 14, 2015
catch errors in app_initialized callbacks
@Carreau Carreau merged commit b521d76 into jupyter:master Sep 14, 2015
@minrk minrk modified the milestone: 4.1 Dec 1, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load failed, save is disabled
4 participants