Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap 3.4 #4271

Merged
merged 1 commit into from
Dec 14, 2018
Merged

bootstrap 3.4 #4271

merged 1 commit into from
Dec 14, 2018

Conversation

minrk
Copy link
Member

@minrk minrk commented Dec 14, 2018

the latest 3.x bugfix release, since we are preparing 5.7.3

and switch from components/ to canonical bootstrap repo, which puts bootstrap.min.js into a dist subdir because components hasn't received the 3.4 update.

and switch from components/ to canonical bootstrap repo, which puts bootstrap.min.js into a `dist` subdir.

components hasn't received the 3.4 update
@minrk minrk added this to the 5.7.3 milestone Dec 14, 2018
@minrk minrk requested a review from takluyver December 14, 2018 11:39
@takluyver
Copy link
Member

I'm assuming that the CI would fail if there was a problem with the installation code.

@takluyver takluyver merged commit 46a887f into jupyter:master Dec 14, 2018
@takluyver
Copy link
Member

@meeseeksdev backport to 5.7.x

meeseeksmachine pushed a commit to meeseeksmachine/notebook that referenced this pull request Dec 14, 2018
minrk added a commit that referenced this pull request Dec 14, 2018
…1-on-5.7.x

Backport PR #4271 on branch 5.7.x (bootstrap 3.4)
@minrk minrk deleted the bs34 branch December 14, 2018 19:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants