Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add japanese translation files #4490

Merged
merged 20 commits into from
Jun 7, 2020
Merged

Add japanese translation files #4490

merged 20 commits into from
Jun 7, 2020

Conversation

mattn
Copy link
Contributor

@mattn mattn commented Mar 19, 2019

  • Add japanese translation files
  • Add fallback to match Accept-Language to UNIX locale.

Browser send Accept-Language ja not ja_JP.

notebook/i18n/nbjs.json Outdated Show resolved Hide resolved
@mattn mattn changed the title Add japanese translations Add japanese translation files Mar 19, 2019
Copy link
Contributor

@crazymaster crazymaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

以下の表記ゆれが気になりました
サーバ vs サーバー
信用 vs 信頼

notebook/i18n/ja_JP/LC_MESSAGES/nbjs.po Outdated Show resolved Hide resolved
notebook/i18n/ja_JP/LC_MESSAGES/nbjs.po Outdated Show resolved Hide resolved
notebook/i18n/ja_JP/LC_MESSAGES/nbjs.po Outdated Show resolved Hide resolved
notebook/i18n/ja_JP/LC_MESSAGES/nbjs.po Outdated Show resolved Hide resolved
notebook/i18n/ja_JP/LC_MESSAGES/nbjs.po Outdated Show resolved Hide resolved
notebook/i18n/ja_JP/LC_MESSAGES/nbjs.po Outdated Show resolved Hide resolved
notebook/i18n/ja_JP/LC_MESSAGES/nbui.po Outdated Show resolved Hide resolved
notebook/i18n/ja_JP/LC_MESSAGES/notebook.po Outdated Show resolved Hide resolved
@mattn
Copy link
Contributor Author

mattn commented Mar 26, 2019

Thanks a lot!

@@ -2,6 +2,7 @@
"domain": "nbjs",
"supported_languages": [
"fr-FR",
"ja_JP",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What browser are you using? This list should probably be consistent in using - or _, and if different browsers do different things, we may need to work around that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google Chrome.

image

The name of UNIX locale on japanese/japan is ja_JP. But the browser send ja.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks @mattn!

@blink1073 blink1073 merged commit dbfa82c into jupyter:master Jun 7, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants