You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Are all the CSS & JS changes necessary for this as well, or did they just get mixed up with the HTML changes you mentioned? If they're necessary, can they have some comments to briefly explain what they are?
Are all the CSS & JS changes necessary for this as well, or did they just get mixed up with the HTML changes you mentioned? If they're necessary, can they have some comments to briefly explain what they are?
For issue#3940, the change in menubar.js is to prevent the dropdown menu is closed when clicking.
The changes in notebook.html are adding "dropdown-toggle" class and data-toggle attribute to tag of submenu because of the when keyboard focus on the dropdown submenu option is actually on the element.
The changes in acc_overwrites.less is to prevent the focus highlight border on submenu options lost after changing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add "dropdown-toggle" and "dropdown-submenu" classes to link element in html.
Addresses #3940