Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve issue #3940: The dropdown submenu at notebook page is not keyboard accessible #4732

Merged
merged 3 commits into from
Jun 7, 2020

Conversation

taohan16
Copy link
Contributor

@taohan16 taohan16 commented Jun 27, 2019

Add "dropdown-toggle" and "dropdown-submenu" classes to link element in html.

Addresses #3940

@takluyver
Copy link
Member

Are all the CSS & JS changes necessary for this as well, or did they just get mixed up with the HTML changes you mentioned? If they're necessary, can they have some comments to briefly explain what they are?

@taohan16
Copy link
Contributor Author

Are all the CSS & JS changes necessary for this as well, or did they just get mixed up with the HTML changes you mentioned? If they're necessary, can they have some comments to briefly explain what they are?

For issue#3940, the change in menubar.js is to prevent the dropdown menu is closed when clicking.
The changes in notebook.html are adding "dropdown-toggle" class and data-toggle attribute to tag of submenu because of the when keyboard focus on the dropdown submenu option is actually on the element.
The changes in acc_overwrites.less is to prevent the focus highlight border on submenu options lost after changing.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 added this to the 6.1 milestone Jun 7, 2020
@blink1073 blink1073 merged commit a90121c into jupyter:master Jun 7, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants