Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to re-establish websocket connection to Gateway #4777

Merged
merged 1 commit into from Aug 7, 2019

Conversation

esevan
Copy link
Contributor

@esevan esevan commented Jul 23, 2019

When notebook (with --gateway-url option) lost the connection to
Gateway, notebook didn't connect to Gateway again although the
websocket connection from the client was still alive.

This change recovers the connection to Gateway to prevent this anomaly.

Signed-off-by: Eunsoo Park esevan.park@gmail.com

This is from jupyter/nb2kg#42 PR

When notebook (with `--gateway-url` option) lost the connection to
Gateway, notebook didn't connect to Gateway again although the
websocket connection from the client was still alive.

This change recovers the connection to Gateway to prevent this anomaly.

Signed-off-by: Eunsoo Park <esevan.park@gmail.com>
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the port Evan!

@lresende lresende added this to the 6.0.1 milestone Aug 6, 2019
@lresende lresende merged commit 20c2c66 into jupyter:master Aug 7, 2019
@esevan esevan deleted the recover_sessions_for_gateway branch August 7, 2019 22:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants