Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gateway only: Ensure launch and request timeouts are in sync #5317

Merged
merged 1 commit into from Apr 6, 2020

Conversation

kevin-bates
Copy link
Member

Prior to this change, the request timeout for a Gateway request was synchronized with KERNEL_LAUNCH_TIMEOUT only if KLT was greater. However, the two are closely associated and KLT should be adjusted if the configurable request_timeout is greater. This change ensures that the two values are synchronized to the greater value. It changes the two configurable timeouts to default to 40 (to match that of KLT) and removes the 2-second pad, since that wasn't helpful and only confused the situation.

These changes were prompted by this issue: jupyter-server/enterprise_gateway#792

Copy link
Member

@lresende lresende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lresende lresende merged commit 7de8df4 into jupyter:master Apr 6, 2020
toonijn pushed a commit to toonijn/notebook that referenced this pull request Apr 9, 2020
…#5317)

Prior to this change, the request timeout for a Gateway request
was synchronized with KERNEL_LAUNCH_TIMEOUT only if KLT 
was greater. However, the two are closely associated and KLT 
should be adjusted if the configurable request_timeout is greater. 
This change ensures that the two values are synchronized to the
greater value. It changes the two configurable timeouts to default
to 40 (to match that of KLT) and removes the 2-second pad, 
since that wasn't helpful and only confused the situation.

These changes were prompted by this issue: jupyter-server/enterprise_gateway#792
@kevin-bates kevin-bates deleted the sync-req-launch-timeout branch January 29, 2021 23:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants