Added nl language

[berendjan]

No description provided.

[kevin-bates]

@berendjan - thank you for your contribution - Dutch localization!

Having not "witnessed" the previous localization additions, it's not entirely clear to me what else is necessary for this. On the surface, everything looks good, but I'd prefer another set of eyes on this particular review.

One reservation I have is that these translations were performed via the Translator Text API. In my experiences with i18n on other projects, this task was typically performed by humans, often with multiple iterations, due to contextual misunderstandings, etc. Assuming you speak/read Dutch, how well do you feel the translations are in preserving the original intent of the given message? It would be good to minimize the number of fixups required because the machine didn't quite interpret intent correctly.

[berendjan]

I noticed that the .po template files .pot are out of sync, the lines to which it refers are often incorrect which leads to not translated text. I'm unsure how to generate new .pot files. I presume this is a problem for all translations (French (fr_FR) and Chinees (zh-CN)).

I raised an issue #5356

[berendjan]

Furthermore, we need more volunteer language checkers to iterate the translations.
For this the translations in the .po files in notebook/notebook/i18n/nl/LC_MESSAGES/ need to be checked.
After translating you need to re-generate the .mo files and the .json file.
Navigate your terminal to notebook/notebook/i18n/ and type the following command:

pybabel compile -D notebook -f -l nl -i nl/LC_MESSAGES/notebook.po -o nl/LC_MESSAGES/notebook.mo
pybabel compile -D nbui -f -l nl -i nl/LC_MESSAGES/nbui.po -o nl/LC_MESSAGES/nbui.mo
po2json -p -F -f jed1.x -d nbjs nl/LC_MESSAGES/nbjs.po nl/LC_MESSAGES/nbjs.json

For testing at runtime:
Jupyter Notebook retrieves the language from the LANG variable in the terminal.
You can set is for the NL language by typing export LANG="nl_NL" in the terminal for this translation in case you have your system settings to English.

[berendjan]

@berendjan - thank you for your contribution - Dutch localization!

Having not "witnessed" the previous localization additions, it's not entirely clear to me what else is necessary for this. On the surface, everything looks good, but I'd prefer another set of eyes on this particular review.

One reservation I have is that these translations were performed via the Translator Text API. In my experiences with i18n on other projects, this task was typically performed by humans, often with multiple iterations, due to contextual misunderstandings, etc. Assuming you speak/read Dutch, how well do you feel the translations are in preserving the original intent of the given message? It would be good to minimize the number of fixups required because the machine didn't quite interpret intent correctly.

@kevin-bates I checked the translations and changed them where I found necessary, but you are absolutely right and probably iterations are necessary. I changed the commit to a [WIP] and gave some instructions above, I also noticed that the .pot and .po files were out of sync and raised issue #5356.

[kevin-bates]

@berendjan - thank you for making an initial "human" pass on the translations. I think that's sufficient to move this forward. I agree with your "ask" for more spell checkers. However, I believe that might not happen for a while and iterating on these messages, post-release, is probably more likely anyway.

I'm good with where this is, but will likely leave this open for a few more days to allow for other reviews.

Thanks again.

[toonijn]

It should indeed be looked at by a human. A quick glance makes some miss translations clear. Another fundamental question:

• What is the translation of 'notebook'? 'Notitieblok' feels awkward. 'Werkblad' (worksheet) makes more sense. (Or just keep the English 'notebook')

[kevin-bates]

@toonijn - thank you for the great review. I'd like to start down the path of putting together a 6.1.0 release and would love to have this included. @berendjan - would it be possible to respond to Toon's review comments fairly soon?

[berendjan]

@toonijn Thank you for your input, it's much appreciated. I have to agree that 'notitieblok' which is a notepad in English sounds weird. I changed everything to notebook as I presume people who come in contact with Jupyter Notebook will be more familiar with the English name even when their system settings are Dutch.

If you have time, please look at the changes and comment away! I'll try to address them asap.

[toonijn]

• "cellenuitvoer" is not a real word. I don't really have een alternative maybe "resultaat van cel", or something like that.
• What do we call a cell of type 'raw'? We just could keep 'raw'.

[toonijn]

Looks good to me!

[kevin-bates]

Fantastic - thank you both @berendjan and @toonijn!

@toonijn - could you please select approve on your review, then I think we'll merge in a day or so to allow others to chime in one last time.

[kevin-bates]

Thanks @toonijn.

@berendjan - if you're all set, please update the title and we'll take the next step.

[berendjan]

@toonijn @kevin-bates Thanks to you both, I removed [WIP] from the title.