Fix broken "Raw cell MIME type" dialog (#3255) #5385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modal dialog for entering a custom MIME type for a "Raw NBConvert"- type cell was broken. This change to the JavaScript code makes the modal dialog appear correctly again, as well as correctly disabling the handling of key presses by the cell editor while the dialog is open. This fixes jupyter#3255.
blink1073
approved these changes
May 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modal dialog for entering a custom MIME type for a "Raw NBConvert"-type cell was broken (see also #3255). This change to the JavaScript code makes the modal dialog appear correctly again. It also fixes the handling of key presses while the dialog is open, preventing the cell editor from handling them.
I ran into this issue today, and figured I could try and have a look at the JavaScript code myself. The fix is really just based on comparing the code in
notebook/static/notebook/js/celltoolbarpresets/rawcell.jswith the code in.../tags.js. I'm not much of a JS developer, so please bear with me :-)