Added functionality to allow filter kernels by Jupyter Enterprise Gat… #5484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eway using KERNEL_USERNAME env var
kevin-bates
reviewed
May 27, 2020
There was a problem hiding this comment.
Thank you for creating this PR @lucabem - it's great to see! I had a few comments - which should simplify things.
I've run with these changes, and things look good. I'll also test with the final changes as well.
One thing I noticed on the EG side is that we're not considering the globally configured authorization lists. I'll open an EG issue for this.
…or class instead of each class method
kevin-bates
approved these changes
May 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We come from here
We have allowed Jupyter Enterprise Gateway to filter kernels by a query param.
This query param is env var KERNEL_USERNAME
@kevin-bates