FIX: removed double link when custom_display_url (#5400) #5544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-bates
reviewed
Jun 20, 2020
There was a problem hiding this comment.
Hi @LaurMerl - thank you for your contribution and welcome to Jupyter!
Your change works nicely. I would recommend though that this messaging also reflect that only one URL will be offered:
Or copy and paste one of these URLs:
http://foo/bar/?token=e2cc24936010a7557df551946fb6852952dfe17030987f19
and make this clause conditional as well.
LaurMerl
force-pushed
the
custom-display-url
branch
from
1573083
to
95348dd
Compare
|
Hey @kevin-bates, good catch, completely overlooked that! |
kevin-bates
approved these changes
Jun 20, 2020
|
@LaurMerl Thanks!!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kevin-bates, @liamhuber, I had a look at the issue in question and have a suggestion on how to fix it.
This is my first contribution so please do let me know if anything about this PR isn't in line with how things are done - and apologies in advance if so!
Thanks in advance!