Improve login shell heuristics #5588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kevin Bates <kbates4@gmail.com>
|
I think updating the help text would be helpful. I don't think we can worry about translations. The nature of those is that they'll need to be revisited from time to time to reflect updates and we can't let that jeopardize doing the right thing. The source changes look good and behave as expected, btw. Thanks David! |
|
Good point, agreed :) I updated the help text, feel free to suggest edits, or even perform them directly if you have the bandwidth. Thanks for the quick response! |
minrk
approved these changes
Jul 7, 2020
There was a problem hiding this comment.
Awesome, thank you!
I think this hits the right balance of:
- not login shell by dfault in most cases
- login shell in an easy-to-grasp circumstance that covers common cases (i.e. not a tty)
- easy to override by setting
terminado_settings['shell_command'] = ['shell', '-l']in config, bypassing the guess above in the circumstances where the guess is wrong (or just don't want to trust it).
This was referenced Nov 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up on #5565, with better heuristics and respecting overrides via
NotebookApp.terminado_settings. Cf. #5565 (comment) for details.I'm wondering whether to also update the documentation for
NotebookApp.terminado_settings, so that it makes it clearer what the shell defaults are and how they can be overridden. Something like:But AFAICS, this would also require updating translations, so I'm not sure it's worth the trouble.