Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update codemirror to 5.56.0+components1 #5637

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

akdor1154
Copy link
Contributor

@akdor1154 akdor1154 commented Jul 30, 2020

This is a fixed re-release of 5.56.0.
Future CM upgrades should go back to the old pattern of e.g. components/codemirror#~5.57.0. (Note the
~tilde) (I can't leave a comment to this effect in the JSON)
To fix #5629 .

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Confirmed in local env. Thank you Jarrad!

@kevin-bates
Copy link
Member

The appveyor failure appears as though it encountered a network-related issue as it suddenly couldn't resolve github.com on the jquery entry in bower.json but I don't have restart privs.

@Carreau - it looks like the appveyor project is under your account. Would you be able to provide me some "job-level" privileges so I have the ability to restart jobs?

I pushed the same change to my fork yesterday and found similar behavior, although a re-build this morning was successful, so I'm proceeding with the merge since the appveyor issues appear unrelated.

@kevin-bates kevin-bates merged commit 6f6f33b into jupyter:master Jul 31, 2020
@Carreau
Copy link
Member

Carreau commented Jul 31, 2020

It look like both Carreau/notebook and Jupyter/notebook existed and were link to this repo, I've deleted mine, and hopefully this will let you see jupyter/notebook in PR and modify it ?

@kevin-bates
Copy link
Member

Thanks Matthias. I still don't have privs for job control in appveyor - only in Travis CI.

@Carreau
Copy link
Member

Carreau commented Jul 31, 2020

Ok, let's try another thing; you should have received invitation on your email(s), note that the lnk to appveyor in the PR status in PRs up until now will be wrong, so you might have to go manually to https://ci.appveyor.com/project/jupyter/notebook

@kevin-bates
Copy link
Member

Beautiful - thank you. I can now see the job-control knobs.

@Carreau
Copy link
Member

Carreau commented Jul 31, 2020 via email

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code not centered properly in cell
3 participants