Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #5811

Merged
merged 1 commit into from Oct 13, 2020
Merged

Fix broken links #5811

merged 1 commit into from Oct 13, 2020

Conversation

adcdr
Copy link
Contributor

@adcdr adcdr commented Oct 13, 2020

The documentation linked below contains 3 rendering errors:
https://jupyter-notebook.readthedocs.io/en/stable/examples/Notebook/What%20is%20the%20Jupyter%20Notebook.html

image

These are caused by limitations in the Sphinx tool used to render the page:
https://docutils.sourceforge.io/FAQ.html#is-nested-inline-markup-possible

This PR fixes them with the least amount of changes.

The documentation linked below contains 3 rendering errors:
https://jupyter-notebook.readthedocs.io/en/stable/examples/Notebook/What%20is%20the%20Jupyter%20Notebook.html

These are caused by limitations in the Sphinx tool used to render the page:
https://docutils.sourceforge.io/FAQ.html#is-nested-inline-markup-possible

This PR fixes them with the least amount of changes.
@adcdr
Copy link
Contributor Author

adcdr commented Oct 13, 2020

The Travis-CI seems to have failed because of a missing node file, this may be fixed by deleting the package.lock file then reinstalling the dependencies.

However I am confident this isn't caused by my changes.

npm ERR! enoent ENOENT: no such file or directory, rename '/home/travis/.nvm/versions/node/v6.9.2/lib/node_modules/.staging/@npmcli/ci-detect-45051f7f' -> '/home/travis/.nvm/versions/node/v6.9.2/lib/node_modules/npm/node_modules/@npmcli/ci-detect'

npm ERR! enoent ENOENT: no such file or directory, rename '/home/travis/.nvm/versions/node/v6.9.2/lib/node_modules/.staging/@npmcli/ci-detect-45051f7f' -> '/home/travis/.nvm/versions/node/v6.9.2/lib/node_modules/npm/node_modules/@npmcli/ci-detect'

npm ERR! enoent This is most likely not a problem with npm itself

npm ERR! enoent and is related to npm not being able to find a file.

npm ERR! enoent 

npm ERR! Please include the following file with any support request:

npm ERR!     /home/travis/build/jupyter/notebook/npm-debug.log

npm ERR! code 1

The command "npm upgrade -g npm" failed and exited with 1 during .

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch - thank you. Yeah, nothing to do with the npm issues which someone has contributed the change for.

@kevin-bates kevin-bates merged commit d85323a into jupyter:master Oct 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants