Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct 'Content-Type' headers #6026

Merged
merged 2 commits into from Mar 31, 2021
Merged

Correct 'Content-Type' headers #6026

merged 2 commits into from Mar 31, 2021

Conversation

faucct
Copy link
Contributor

@faucct faucct commented Mar 30, 2021

No description provided.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @faucct - thank you for the pull request. As noted in the comment, there will need to be some extra merge logic to account for multiple headers dictionaries.

notebook/gateway/managers.py Show resolved Hide resolved
@faucct
Copy link
Contributor Author

faucct commented Mar 31, 2021

A single check have failed, but I don't think it is related to the changes. Could you restart it, please?

@blink1073
Copy link
Member

I kicked the Selenium tests

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @faucct - thank you.

@kevin-bates kevin-bates merged commit 7e8fb1a into jupyter:master Mar 31, 2021
@kevin-bates
Copy link
Member

@faucct - thank you for the contribution. Since the notebook server is transitioning to jupyter_server, it would be fantastic if you could make this change there as well.

faucct added a commit to faucct/jupyter_server that referenced this pull request Apr 9, 2021
@faucct faucct deleted the patch-1 branch April 9, 2021 06:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants