Correct 'Content-Type' headers#6026
Merged
kevin-bates merged 2 commits intojupyter:masterfrom Mar 31, 2021
Merged
Conversation
kevin-bates
reviewed
Mar 30, 2021
Member
kevin-bates
left a comment
kevin-bates
left a comment
There was a problem hiding this comment.
Hi @faucct - thank you for the pull request. As noted in the comment, there will need to be some extra merge logic to account for multiple headers dictionaries.
Contributor
Author
|
A single check have failed, but I don't think it is related to the changes. Could you restart it, please? |
Contributor
|
I kicked the Selenium tests |
kevin-bates
approved these changes
Mar 31, 2021
Member
kevin-bates
left a comment
kevin-bates
left a comment
There was a problem hiding this comment.
Looks good @faucct - thank you.
Member
|
@faucct - thank you for the contribution. Since the notebook server is transitioning to jupyter_server, it would be fantastic if you could make this change there as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.