Revert "do not apply asyncio patch for tornado >=6.1" #6052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 73c9ac1.
|
Tests failures are on Windows, which is where I would expect behavior to change, but the same failures seem to have cropped up on master and are all terminal-related. Maybe terminado or something? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revert #5907
While tornado 6.1 adds support for running on proactor, avoiding an error, I think it's still better to use Selector since it avoids putting add_reader / writer in a thread.
Since ~all of our events are via add/remove_reader, keeping those on the main thread still seems preferable.