Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "do not apply asyncio patch for tornado >=6.1" #6052

merged 1 commit into from May 11, 2021


Copy link

@minrk minrk commented May 9, 2021

revert #5907

While tornado 6.1 adds support for running on proactor, avoiding an error, I think it's still better to use Selector since it avoids putting add_reader / writer in a thread.

Since ~all of our events are via add/remove_reader, keeping those on the main thread still seems preferable.

Copy link
Member Author

minrk commented May 9, 2021

Tests failures are on Windows, which is where I would expect behavior to change, but the same failures seem to have cropped up on master and are all terminal-related. Maybe terminado or something?

Copy link

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@blink1073 blink1073 added this to the 6.4 milestone May 11, 2021
@blink1073 blink1073 merged commit 008a6c0 into jupyter:master May 11, 2021
@minrk minrk deleted the keep-no-proactor branch May 13, 2021 10:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants