Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"#element".tooltip is not a function on home page fixed. #6070

Merged
merged 4 commits into from
May 24, 2021

Conversation

Bloepcode
Copy link
Contributor

Closes #6062

Hello, this is my first time contributing to Github.
In the notebook/templates/tree.html file was there a $ character missing which resulted in an "#element".tooltip is not a function error in the console, I fixed this issue by adding the $ character. Then I also found out that this line: $('#element').tooltip('enable') that uses jquery was ran first, only then jquery was imported (<script src="{{ static_url("tree/js/main.min.js") }}" type="text/javascript" charset="utf-8"></script>), this also resulted in an error, I swapped them and now it works.
I hope I did not miss anything.

Kind regards, Ilay Hamer.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indeed appears to be fixed - thank you.

Since I'm not familiar with this area of the code, it would be great to get a confirmation from someone that can determine if there's any hidden issue here.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@blink1073 blink1073 added this to the 6.4 milestone May 24, 2021
@blink1073 blink1073 added the bug label May 24, 2021
@kevin-bates kevin-bates merged commit 56416cb into jupyter:master May 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console error: "#element".tooltip is not a function (in the home page)
3 participants