Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jupyter_client warning #6178

Merged
merged 1 commit into from Sep 9, 2021
Merged

Fix jupyter_client warning #6178

merged 1 commit into from Sep 9, 2021

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Sep 9, 2021 •
edited

Fix the warning:

/home/martin/miniconda3/envs/xeus-python/lib/python3.9/json/encoder.py:257: 
UserWarning: date_default is deprecated since jupyter_client 7.0.0. Use jupyter_client.jsonutil.json_default.

kevin-bates
kevin-bates approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, confirmed the previous warnings are no longer present. Thank you @martinRenou!

@kevin-bates kevin-bates merged commit 8c145ad into jupyter:master Sep 9, 2021
@kevin-bates
Copy link
Member

The test failures appear unrelated.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevin-bates kevin-bates kevin-bates approved these changes

Assignees
No one assigned
Labels
status:resolved-locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martinRenou @kevin-bates