Fix: CI error for python 3.6 & macOS #6215
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I'm agree with killing python 3.6, but until it not done - tests should pass Op ma 22 nov. 2021 23:02 schreef Kevin Bates ***@***.***>:…
***@***.**** commented on this pull request. Since Python 3.6 will be end-of-life in a month <https://devguide.python.org/#status-of-python-branches>, should we take this opportunity to replace 3.6 with 3.10 in the CI matrix instead? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6215 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD2KMM7MD7IG3YNSCEOEFLTUNK4XJANCNFSM5GVJPD4A> .
* TST: don't look in user site for serverextensions
This is a fix for jupyter#6164 `nest_asyncio` must be applied before any async tasks have been created otherwise there could be tasks queued that are unpatched, and thus do not respect nested loops. An example of an unpatched task can be seen in the original issue: ``` <Task pending coro=<HTTP1ServerConnection._server_request_loop() running at /apps/python3/lib/python3.7/site-packages/tornado/http1connection.py:823> ``` which originates from Tornado. A similar issue was reported in `nest-asyncio`: erdewit/nest_asyncio#22 where the solution is to call `apply` on import so that unpatched tasks do not get created.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.