Fix: CI error for python 3.6 & macOS #6215
Conversation
Run actions/setup-python@v1 Error: Version 3.6 with arch x64 not found
There was a problem hiding this comment.
Since Python 3.6 will be end-of-life in a month, should we take this opportunity to replace 3.6 with 3.10 in the CI matrix instead?
|
I'm agree with killing python 3.6, but until it not done - tests should pass
Op ma 22 nov. 2021 23:02 schreef Kevin Bates ***@***.***>:
… ***@***.**** commented on this pull request.
Since Python 3.6 will be end-of-life in a month
<https://devguide.python.org/#status-of-python-branches>, should we take
this opportunity to replace 3.6 with 3.10 in the CI matrix instead?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6215 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD2KMM7MD7IG3YNSCEOEFLTUNK4XJANCNFSM5GVJPD4A>
.
|
|
@penguinolog, do you mind making the update to the test matrix that replaces 3.6 with 3.10? |
If main maintainers agree - I'll be happy |
* TST: don't look in user site for serverextensions
This is a fix for jupyter#6164 `nest_asyncio` must be applied before any async tasks have been created otherwise there could be tasks queued that are unpatched, and thus do not respect nested loops. An example of an unpatched task can be seen in the original issue: ``` <Task pending coro=<HTTP1ServerConnection._server_request_loop() running at /apps/python3/lib/python3.7/site-packages/tornado/http1connection.py:823> ``` which originates from Tornado. A similar issue was reported in `nest-asyncio`: erdewit/nest_asyncio#22 where the solution is to call `apply` on import so that unpatched tasks do not get created.
* Automated Changelog Entry for 6.4.6 on master * Update CHANGELOG.md Co-authored-by: GitHub Action <41898282+github-actions[bot]@users.noreply.github.com>
SHA256 hashes: notebook-6.4.6-py3-none-any.whl: 5cad068fa82cd4fb98d341c052100ed50cd69fbfb4118cb9b8ab5a346ef27551 notebook-6.4.6.tar.gz: 7bcdf79bd1cda534735bd9830d2cbedab4ee34d8fe1df6e7b946b3aab0902ba3
penguinolog
force-pushed
the
ci_fix_not_supported
branch
from
e69a180
to
7738a9c
Compare
|
@kevin-bates removed all python 3.6 links and replaced by python 3.10 (except tests -> it's still using lowest supported version) |
|
Python 3.6 is dead. Can we move forward? |
There was a problem hiding this comment.
The file changes look good to me, but I don't know what to make of the extraneous commits going on (not a GH expert enough to know if this is a concern).
Would @Zsailer or @blink1073 be able to take a look?
Also, since we probably shouldn't drop official support for 3.6 in a patch release, I'm going to open an issue for dropping 3.6 and adding 3.10 "officially".
Yeah, agreed that should be a minor release. |
Run actions/setup-python@v1
Error: Version 3.6 with arch x64 not found
Exclude nonexistent configurations from matrix